redhat_subscription: refactor of internal Rhsm class #6658
Merged
+15
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
module
felixfontein
added
check-before-release
Not to minimize the recommendation: would it be really something needs to be aware by reading release notes? |
|
We have the general rule of always having a changelog fragment for any code change that affects |
The two RegistrationBase & Rhsm classes were copied from the ones in the shared module_utils.redhat module; that said: - the versions here got improvements over the years - the RegistrationBase in module_utils.redhat is used only by the RHN modules, which are deprecated and slated for removal Hence, the classes here can be kept and simplified a bit: - fold the non-dummy content of RegistrationBase into Rhsm: there is no more need for the separate RegistrationBase base class - drop the init arguments "username", "password", and "token": the instance variables of them are not used anywhere, as the needed credentials (together with other variables) are passed to the register() method - create the Rhsm object later in main(), after the AnsibleModule creation and the uid check: this avoids the creation of Rhsm with a null module variable, changing it later There should be no behaviour change.
ptoscano
force-pushed
the
redhat_subscription-rhsm-refactor
branch
from
2d81aec to
deebdb8
Compare
felixfontein
approved these changes
Jun 10, 2023
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6667 🤖 @patchback |
|
@ptoscano thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Jun 10, 2023
The two RegistrationBase & Rhsm classes were copied from the ones in the shared module_utils.redhat module; that said: - the versions here got improvements over the years - the RegistrationBase in module_utils.redhat is used only by the RHN modules, which are deprecated and slated for removal Hence, the classes here can be kept and simplified a bit: - fold the non-dummy content of RegistrationBase into Rhsm: there is no more need for the separate RegistrationBase base class - drop the init arguments "username", "password", and "token": the instance variables of them are not used anywhere, as the needed credentials (together with other variables) are passed to the register() method - create the Rhsm object later in main(), after the AnsibleModule creation and the uid check: this avoids the creation of Rhsm with a null module variable, changing it later There should be no behaviour change. (cherry picked from commit 42f7531)
felixfontein
pushed a commit
that referenced
this pull request
Jun 10, 2023
…of internal Rhsm class (#6667) redhat_subscription: refactor of internal Rhsm class (#6658) The two RegistrationBase & Rhsm classes were copied from the ones in the shared module_utils.redhat module; that said: - the versions here got improvements over the years - the RegistrationBase in module_utils.redhat is used only by the RHN modules, which are deprecated and slated for removal Hence, the classes here can be kept and simplified a bit: - fold the non-dummy content of RegistrationBase into Rhsm: there is no more need for the separate RegistrationBase base class - drop the init arguments "username", "password", and "token": the instance variables of them are not used anywhere, as the needed credentials (together with other variables) are passed to the register() method - create the Rhsm object later in main(), after the AnsibleModule creation and the uid check: this avoids the creation of Rhsm with a null module variable, changing it later There should be no behaviour change. (cherry picked from commit 42f7531) Co-authored-by: Pino Toscano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The two
RegistrationBase&Rhsmclasses were copied from the ones in the sharedmodule_utils.redhatmodule; that said:RegistrationBaseinmodule_utils.redhatis used only by the RHN modules, which are deprecated and slated for removalHence, the classes here can be kept and simplified a bit:
RegistrationBaseintoRhsm: there is no more need for the separateRegistrationBasebase classusername,password, andtoken: the instance variables of them are not used anywhere, as the needed credentials (together with other variables) are passed to theregister()methodRhsmobject later inmain(), after theAnsibleModulecreation and the uid check: this avoids the creation ofRhsmwith a null module variable, changing it laterThere should be no behaviour change.
ISSUE TYPE
COMPONENT NAME
redhat_subscription